feat(framework:skip) Update Docker Compose distributed files for 1.13.0
#4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
changed the title
distributed files for 1.13.0
chongshenng
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Thanks @Robert-Steiner. Similar to #4413, let's set the image tags to nightly.
| @@ -2,6 +2,10 @@ services: | |||
| superlink: | |||
| image: flwr/superlink:${FLWR_VERSION:-1.12.0} | |||
There was a problem hiding this comment.
Suggested change
| image: flwr/superlink:${FLWR_VERSION:-1.12.0} | |
| image: flwr/superlink:${FLWR_VERSION:-1.12.0} |
Same as this comment. This should be nightly for now, until 1.13 is released.
| build: | ||
| context: ${PROJECT_DIR:-.} | ||
| dockerfile_inline: | | ||
| FROM flwr/superexec:${FLWR_VERSION:-1.12.0} | ||
| FROM flwr/serverapp:${FLWR_VERSION:-1.12.0} |
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
requested review from
Moep90,
tanertopal and
danieljanes
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Updates the Docker Compose complete setup to incorporate the upcoming 1.13.0 changes.
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?